mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Olliver Schinagl <o.schinagl@ultimaker.com>
Cc: linux-kernel@vger.kernel.org, Olliver Schinagl <oliver@schinagl.nl>
Subject: Re: [PATCH] hrtimer: add hrtimer_start_now()
Date: Thu, 22 Jan 2015 20:35:24 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1501222032570.5526@nanos> (raw)
In-Reply-To: <54C0D9D7.4010903@ultimaker.com>

On Thu, 22 Jan 2015, Olliver Schinagl wrote:
> On 22-01-15 12:01, Thomas Gleixner wrote:
> > Aside of that, what's wrong with doing:
> > 
> >        static const ktime_t ktime_zero = { .tv64 = 0 };
> > 
> >        hrtimer_start(timer, ktime_zero, HRTIMER_MODE_REL);
> I guess the same could be said for hrtimer_forward_now I suppose. It was just
> intended as a little helper, with emphasis on helper.

Well, no. htimer_forward_now() is mainly there to maintain a periodic
schedule which takes gaps into account.

I have nothing against the start_now() helper, but it's simpler and
less code with start relative than with abs and get_time().

Thanks,

	tglx

      reply	other threads:[~2015-01-22 19:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22  6:12 Olliver Schinagl
2015-01-22 11:01 ` Thomas Gleixner
2015-01-22 11:07   ` Olliver Schinagl
2015-01-22 19:35     ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1501222032570.5526@nanos \
    --to=tglx@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o.schinagl@ultimaker.com \
    --cc=oliver@schinagl.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®