From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754072AbbA2P4B (ORCPT ); Thu, 29 Jan 2015 10:56:01 -0500 Received: from resqmta-ch2-06v.sys.comcast.net ([69.252.207.38]:38394 "EHLO resqmta-ch2-06v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753588AbbA2P4A (ORCPT ); Thu, 29 Jan 2015 10:56:00 -0500 Date: Thu, 29 Jan 2015 09:55:56 -0600 (CST) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Vladimir Davydov cc: Andrew Morton , Joonsoo Kim , Pekka Enberg , David Rientjes , Johannes Weiner , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm v2 1/3] slub: never fail to shrink cache In-Reply-To: <20150129080726.GB11463@esperanza> Message-ID: References: <012683fc3a0f9fb20a288986fd63fe9f6d25e8ee.1422461573.git.vdavydov@parallels.com> <20150128135752.afcb196d6ded7c16a79ed6fd@linux-foundation.org> <20150129080726.GB11463@esperanza> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Jan 2015, Vladimir Davydov wrote: > Come to think of it, do we really need to optimize slab placement in > kmem_cache_shrink? None of its users except shrink_store expects it - > they just want to purge the cache before destruction, that's it. May be, > we'd better move slab placement optimization to a separate SLUB's > private function that would be called only by shrink_store, where we can > put up with kmalloc failures? Christoph, what do you think? The slabinfo tool invokes kmem_cache_shrink to optimize placement. Run slabinfo -s which can then be used to reduce the fragmentation.