From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755861AbbA2QWU (ORCPT ); Thu, 29 Jan 2015 11:22:20 -0500 Received: from resqmta-po-10v.sys.comcast.net ([96.114.154.169]:46147 "EHLO resqmta-po-10v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752035AbbA2QWT (ORCPT ); Thu, 29 Jan 2015 11:22:19 -0500 Date: Thu, 29 Jan 2015 10:22:16 -0600 (CST) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Vladimir Davydov cc: Andrew Morton , Joonsoo Kim , Pekka Enberg , David Rientjes , Johannes Weiner , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm v2 1/3] slub: never fail to shrink cache In-Reply-To: <20150129161739.GE11463@esperanza> Message-ID: References: <012683fc3a0f9fb20a288986fd63fe9f6d25e8ee.1422461573.git.vdavydov@parallels.com> <20150128135752.afcb196d6ded7c16a79ed6fd@linux-foundation.org> <20150129080726.GB11463@esperanza> <20150129161739.GE11463@esperanza> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Jan 2015, Vladimir Davydov wrote: > Yeah, but the tool just writes 1 to /sys/kernel/slab/cache/shrink, i.e. > invokes shrink_store(), and I don't propose to remove slab placement > optimization from there. What I propose is to move slab placement > optimization from kmem_cache_shrink() to shrink_store(), because other > users of kmem_cache_shrink() don't seem to need it at all - they just > want to release empty slabs. Such a change wouldn't affect the behavior > of `slabinfo -s` at all. Well we have to go through the chain of partial slabs anyways so its easy to do the optimization at that point.