From: Christoph Lameter <cl@linux.com>
To: "Andrew G. Morgan" <morgan@kernel.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
"Ted Ts'o" <tytso@mit.edu>, Andrew Lutomirski <luto@kernel.org>,
Andrew Morton <akpm@linuxfoundation.org>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
Linux API <linux-api@vger.kernel.org>,
Austin S Hemmelgarn <ahferroin7@gmail.com>,
linux-security-module <linux-security-module@vger.kernel.org>,
Aaron Jones <aaronmdjones@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Serge Hallyn <serge.hallyn@canonical.com>,
Markku Savela <msa@moth.iki.fi>,
Kees Cook <keescook@chromium.org>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [RFC] capabilities: Ambient capabilities
Date: Mon, 30 Mar 2015 07:55:04 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.11.1503300754070.5031@gentwo.org> (raw)
In-Reply-To: <CALQRfL7AyadFcu9JqtC6FGnuuqY7zbnFAL81XnwBvn0o6c6UWQ@mail.gmail.com>
On Sat, 14 Mar 2015, Andrew G. Morgan wrote:
>
> I thought I did. Please implement a lockable secure bit and I will
Would this suffice? It puts the CAP_SETPCAP limitation back to how it
was in my earlier patch.
Subject: ambient caps: Allow disabling with SETPCAP
Do not allow setting ambient caps if CAP_SETPCAP is not set.
Signed-off-by: Christoph Lameter <cl@linux.com>
Index: linux/security/commoncap.c
===================================================================
--- linux.orig/security/commoncap.c
+++ linux/security/commoncap.c
@@ -962,6 +962,9 @@ int cap_task_prctl(int option, unsigned
if (((!cap_valid(arg3)) | arg4 | arg5))
return -EINVAL;
+ if (!ns_capable(current_user_ns(), CAP_SETPCAP))
+ return -EPERM;
+
if (arg2 == PR_CAP_AMBIENT_GET) {
return !!cap_raised(current_cred()->cap_ambient, arg3);
} else if (arg2 != PR_CAP_AMBIENT_RAISE &&
next prev parent reply other threads:[~2015-03-30 12:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 18:08 Andy Lutomirski
2015-03-12 21:49 ` Kees Cook
2015-03-12 22:10 ` Andrew G. Morgan
2015-03-12 22:27 ` Andrew Lutomirski
2015-03-13 13:24 ` Andrew G. Morgan
2015-03-13 16:06 ` Christoph Lameter
2015-03-13 17:58 ` Andy Lutomirski
2015-03-13 18:52 ` Christoph Lameter
2015-03-13 17:57 ` Andy Lutomirski
2015-03-13 18:52 ` Kees Cook
2015-03-13 19:03 ` Andy Lutomirski
2015-03-13 19:54 ` Kees Cook
2015-03-14 21:09 ` Andrew G. Morgan
2015-03-14 21:45 ` Andy Lutomirski
2015-03-14 22:17 ` Andrew G. Morgan
2015-03-14 22:53 ` Andy Lutomirski
2015-03-14 22:55 ` Andy Lutomirski
2015-03-15 0:04 ` Andrew G. Morgan
2015-03-30 12:55 ` Christoph Lameter [this message]
2015-03-30 14:31 ` Andy Lutomirski
2015-03-30 15:05 ` Christoph Lameter
2015-04-09 15:25 ` Christoph Lameter
2015-04-23 14:01 ` Christoph Lameter
2015-04-24 17:53 ` Serge Hallyn
2015-04-24 18:41 ` Andy Lutomirski
2015-04-24 19:09 ` Serge Hallyn
2015-04-24 19:25 ` Christoph Lameter
2015-04-24 19:53 ` Andy Lutomirski
2015-04-24 20:13 ` Christoph Lameter
2015-04-24 20:18 ` Andy Lutomirski
2015-04-24 21:15 ` Serge E. Hallyn
2015-04-24 22:55 ` Andy Lutomirski
2015-04-25 2:45 ` Serge Hallyn
2015-04-27 14:55 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1503300754070.5031@gentwo.org \
--to=cl@linux.com \
--cc=aaronmdjones@gmail.com \
--cc=ahferroin7@gmail.com \
--cc=akpm@linuxfoundation.org \
--cc=corbet@lwn.net \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=morgan@kernel.org \
--cc=msa@moth.iki.fi \
--cc=mtk.manpages@gmail.com \
--cc=serge.hallyn@canonical.com \
--cc=tytso@mit.edu \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®