From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934976AbbEOUaX (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 May 2015 16:30:23 -0400
Received: from www.linutronix.de ([62.245.132.108]:42990 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S934056AbbEOUaV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 May 2015 16:30:21 -0400
Date: Fri, 15 May 2015 22:29:50 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Stefan Agner <stefan@agner.ch>
cc: shawn.guo@linaro.org, kernel@pengutronix.de, jason@lakedaemon.net,
        marc.zyngier@arm.com, linux@arm.linux.org.uk,
        u.kleine-koenig@pengutronix.de, olof@lixom.net, arnd@arndb.de,
        daniel.lezcano@linaro.org, mark.rutland@arm.com, pawel.moll@arm.com,
        robh+dt@kernel.org, ijc+devicetree@hellion.org.uk,
        galak@codeaurora.org, mcoquelin.stm32@gmail.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 04/12] irqchip: vf610-mscm: support NVIC parent
In-Reply-To: <6af49d55159182668c21480e0fbaa85c@agner.ch>
Message-ID: <alpine.DEB.2.11.1505152229360.4225@nanos>
References: <1431203982-13217-1-git-send-email-stefan@agner.ch> <1431203982-13217-5-git-send-email-stefan@agner.ch> <alpine.DEB.2.11.1505151237531.4225@nanos> <6af49d55159182668c21480e0fbaa85c@agner.ch>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 15 May 2015, Stefan Agner wrote:

> On 2015-05-15 12:39, Thomas Gleixner wrote:
> > On Sat, 9 May 2015, Stefan Agner wrote:
> >> -	irq_chip_unmask_parent(data);
> >> +	if (parent->chip->irq_enable)
> >> +		parent->chip->irq_enable(parent);
> >> +	else
> >> +		parent->chip->irq_unmask(parent);
> > 
> > Why are you not creating irq_chip_enable_parent() which would have
> > been the proper function anyway?
> > 
> 
> Will add that...
> 
> Btw, have you had a chance to look at 1/12? I added a helper there too

Yes 1/12 is fine ...