From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753484AbbEROqe (ORCPT ); Mon, 18 May 2015 10:46:34 -0400 Received: from www.linutronix.de ([62.245.132.108]:49511 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753202AbbEROqc (ORCPT ); Mon, 18 May 2015 10:46:32 -0400 Date: Mon, 18 May 2015 16:46:42 +0200 (CEST) From: Thomas Gleixner To: Jiang Liu cc: linux-kernel@vger.kernel.org Subject: Re: Are we still willing to pay the cost of moving include/linux/irqdesc.h into kernel/irq/? In-Reply-To: <5559B574.7070402@linux.intel.com> Message-ID: References: <5559B574.7070402@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jiang, On Mon, 18 May 2015, Jiang Liu wrote: > Hi Thomas, > When refining irq related data structures, I found once we had > a plan to move include/linux/irqdesc.h into kernel/irq/, and I have I had that plan for two reasons: 1) Is was tired of chasing the abuse of irq_desc 2) We wanted to move irq descriptor memory allocation when affinity changes to a different node. > basic ideas about how to achieve the goal as: > 1) de-inline accessor functions in irqdesc.h and move the declaration > into linux/irq.h. > 2) remove reference to irq_desc->xxxx from drivers one by one (this > step is simple) Not sure. drivers/irqchip pretty much needs it and we have other demeltiplex handlers which need it as well. > 3) remove reference to irq_desc->xxxx from arch (this step is hard) Same issue as #2 > 4) move irqdesc.h into kernel/irq/ > > But are we still willing to pay the cost of converting inline access > helpers into normal functions? I dont think so. Thanks, tglx