From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754067AbbERVGH (ORCPT ); Mon, 18 May 2015 17:06:07 -0400 Received: from www.linutronix.de ([62.245.132.108]:51218 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753905AbbERVGE (ORCPT ); Mon, 18 May 2015 17:06:04 -0400 Date: Mon, 18 May 2015 23:06:14 +0200 (CEST) From: Thomas Gleixner To: Dave Hansen cc: linux-kernel@vger.kernel.org, x86@kernel.org, dave.hansen@linux.intel.com, oleg@redhat.com Subject: Re: [PATCH 12/19] x86: make is_64bit_mm() widely available In-Reply-To: <20150508185953.490E9116@viggo.jf.intel.com> Message-ID: References: <20150508185948.4C19F4B0@viggo.jf.intel.com> <20150508185953.490E9116@viggo.jf.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 May 2015, Dave Hansen wrote: > The uprobes code has a nice helper, is_64bit_mm(), that consults both > the runtime and compile-time flags for 32-bit support. Instead of > reinventing the wheel, pull it in to an x86 header so we can use it > for MPX. > > I prefer passing the mm around to test_thread_flag(TIF_IA32) because > it makes it explicit where the context is coming from. Ack. > It will also make it easier if we ever need to access the MPX > structures from another process. Do we really want to go there? Otherwise: Reviewed-by: Thomas Gleixner