From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932440AbbERVHT (ORCPT ); Mon, 18 May 2015 17:07:19 -0400 Received: from www.linutronix.de ([62.245.132.108]:51230 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932081AbbERVGz (ORCPT ); Mon, 18 May 2015 17:06:55 -0400 Date: Mon, 18 May 2015 23:07:05 +0200 (CEST) From: Thomas Gleixner To: Dave Hansen cc: linux-kernel@vger.kernel.org, x86@kernel.org, dave.hansen@linux.intel.com Subject: Re: [PATCH 13/19] x86, mpx: Add temporary variable to reduce masking In-Reply-To: <20150508185954.3E7221E6@viggo.jf.intel.com> Message-ID: References: <20150508185948.4C19F4B0@viggo.jf.intel.com> <20150508185954.3E7221E6@viggo.jf.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 May 2015, Dave Hansen wrote: > When we allocate a bounds table, we call mmap(), then add a > "valid" bit to the value before storing it in to the bounds > directory. > > If we fail along the way, we go and mask that valid bit > _back_ out. That seems a little silly, and this makes it > much more clear when we have a plain address versus an > actual table _entry_. > > Signed-off-by: Dave Hansen Reviewed-by: Thomas Gleixner