From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932587AbbERVKm (ORCPT ); Mon, 18 May 2015 17:10:42 -0400 Received: from www.linutronix.de ([62.245.132.108]:51244 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932492AbbERVKk (ORCPT ); Mon, 18 May 2015 17:10:40 -0400 Date: Mon, 18 May 2015 23:10:50 +0200 (CEST) From: Thomas Gleixner To: Dave Hansen cc: linux-kernel@vger.kernel.org, x86@kernel.org, dave.hansen@linux.intel.com Subject: Re: [PATCH 14/19] x86, mpx: new directory entry to addr helper In-Reply-To: <20150508185954.0BB7D1B1@viggo.jf.intel.com> Message-ID: References: <20150508185948.4C19F4B0@viggo.jf.intel.com> <20150508185954.0BB7D1B1@viggo.jf.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 May 2015, Dave Hansen wrote: > Currently, to get from a bounds directory entry to the virtual > address of a bounds table, we simply mask off a few low bits. > However, the set of bits we mask off is different for 32 and > 64-bit binaries. > > This breaks the operation out in to a helper function and also > adds a temporary variable to store the result until we are > sure we are returning one. > > Signed-off-by: Dave Hansen > +static unsigned long mpx_bd_entry_to_bt_addr(struct mm_struct *mm, > + unsigned long bd_entry) Nit: Please adjust the second line so the arguments are horizontally aligned. static unsigned long mpx_bd_entry_to_bt_addr(struct mm_struct *mm, unsigned long bd_entry) Aside of that: Reviewed-by: Thomas Gleixner