From: Thomas Gleixner <tglx@linutronix.de>
To: Feng Wu <feng.wu@intel.com>
Cc: joro@8bytes.org, dwmw2@infradead.org, jiang.liu@linux.intel.com,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [v6 3/8] iommu, x86: Implement irq_set_vcpu_affinity for intel_ir_chip
Date: Thu, 21 May 2015 12:48:04 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1505211244110.4225@nanos> (raw)
In-Reply-To: <1432191555-3516-4-git-send-email-feng.wu@intel.com>
On Thu, 21 May 2015, Feng Wu wrote:
> +static int intel_ir_set_vcpu_affinity(struct irq_data *data, void *vcpu_info)
> +{
> + struct intel_ir_data *ir_data = data->chip_data;
> + struct irte *irte_pi = &ir_data->irte_pi_entry;
> + struct vcpu_data *vcpu_pi_info;
> +
> + /* stop posting interrupts, back to remapping mode */
> + if (!vcpu_info)
> + modify_irte(&ir_data->irq_2_iommu, &ir_data->irte_entry);
> + else {
We add braces to both branches if one requires it.
> + vcpu_pi_info = (struct vcpu_data *)vcpu_info;
> + memcpy(irte_pi, &ir_data->irte_entry, sizeof(struct irte));
This lacks a comment WHY you copy irte_entry to irte_pi_entry and WHY
we have two seperate entries stored in ir_data.
Thanks,
tglx
next prev parent reply other threads:[~2015-05-21 10:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 6:59 [v6 0/8] Add VT-d Posted-Interrupts support - IOMMU part Feng Wu
2015-05-21 6:59 ` [v6 1/8] iommu: Add new member capability to struct irq_remap_ops Feng Wu
2015-05-21 6:59 ` [v6 2/8] iommu: dmar: Extend struct irte for VT-d Posted-Interrupts Feng Wu
2015-05-21 6:59 ` [v6 3/8] iommu, x86: Implement irq_set_vcpu_affinity for intel_ir_chip Feng Wu
2015-05-21 10:48 ` Thomas Gleixner [this message]
2015-05-22 1:02 ` Wu, Feng
2015-05-21 6:59 ` [v6 4/8] iommu, x86: No need to migrating irq for VT-d Posted-Interrupts Feng Wu
2015-05-21 6:59 ` [v6 5/8] iommu, x86: Add cap_pi_support() to detect VT-d PI capability Feng Wu
2015-05-21 6:59 ` [v6 6/8] iommu, x86: Setup Posted-Interrupts capability for Intel iommu Feng Wu
2015-05-21 10:51 ` Thomas Gleixner
2015-05-22 1:03 ` Wu, Feng
2015-05-21 6:59 ` [v6 7/8] iommu, x86: define irq_remapping_cap() Feng Wu
2015-05-21 6:59 ` [v6 8/8] iommu, x86: Properly handler PI for IOMMU hotplug Feng Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1505211244110.4225@nanos \
--to=tglx@linutronix.de \
--cc=dwmw2@infradead.org \
--cc=feng.wu@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jiang.liu@linux.intel.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®