From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751001AbbEYQ5B (ORCPT ); Mon, 25 May 2015 12:57:01 -0400 Received: from www.linutronix.de ([62.245.132.108]:49473 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbbEYQ5A (ORCPT ); Mon, 25 May 2015 12:57:00 -0400 Date: Mon, 25 May 2015 18:56:58 +0200 (CEST) From: Thomas Gleixner To: Alexandre Belloni cc: Sylvain Rochet , Daniel Lezcano , Nicolas Ferre , Boris Brezillon , Maxime Ripard , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clockevents: don't suspend/resume if unused In-Reply-To: <20150116165914.GS3843@piout.net> Message-ID: References: <1421399151-26800-1-git-send-email-alexandre.belloni@free-electrons.com> <20150116092014.GA27945@gradator.net> <20150116165914.GS3843@piout.net> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Jan 2015, Alexandre Belloni wrote: > Hi, > > On 16/01/2015 at 10:20:14 +0100, Sylvain Rochet wrote : > > > + if (dev->suspend && dev->mode != CLOCK_EVT_MODE_UNUSED) > > > > I wonder if we should use > CLOCK_EVT_MODE_SHUTDOWN > > (or CLOCK_EVT_MODE_UNUSED || CLOCK_EVT_MODE_SHUTDOWN) instead of > > !CLOCK_EVT_MODE_UNUSED. > > > > I'll let Thomas or Daniel decide :) But I'm open to that. I'm unsure about the shutdown part. shutdown can be an intermediate state where its not a given, that the clocks are disabled. I pick it up as is. Thanks, tglx