From: Thomas Gleixner <tglx@linutronix.de>
To: Feng Wu <feng.wu@intel.com>
Cc: joro@8bytes.org, dwmw2@infradead.org, jiang.liu@linux.intel.com,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [v8 3/9] iommu, x86: Implement irq_set_vcpu_affinity for intel_ir_chip
Date: Tue, 2 Jun 2015 15:59:09 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1506021501070.3786@nanos> (raw)
In-Reply-To: <1432699544-17444-4-git-send-email-feng.wu@intel.com>
On Wed, 27 May 2015, Feng Wu wrote:
> + /* stop posting interrupts, back to remapping mode */
> + if (!vcpu_info) {
> + modify_irte(&ir_data->irq_2_iommu, &ir_data->irte_entry);
> + } else {
> + vcpu_pi_info = (struct vcpu_data *)vcpu_info;
> +
> + /*
> + * "ir_data->irte_entry" saves the remapped format of IRTE,
> + * which being a cached irte is still updated when setting
> + * the affinity even when we are in posted mode. So this make
s/make/makes/
> + * it possible to switch back to remapped mode from posted mode,
> + * we can just set "ir_data->irte_entry" to hardware for that
> + * purpose. Here we store the posted format of IRTE in another
> + * new member "ir_data->irte_pi_entry" to not corrupt
Remove the 'another new member' please. That member is not longer new
once that patch is applied.
Now there is another question. Are we actually using that pi_entry
cached value for anything else than this code here? If not, we can do
this on the stack and avoid the extra storage in ir_data.
Thanks,
tglx
next prev parent reply other threads:[~2015-06-02 13:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 4:05 [v8 0/9] Add VT-d Posted-Interrupts support - IOMMU part Feng Wu
2015-05-27 4:05 ` [v8 1/9] iommu: Add new member capability to struct irq_remap_ops Feng Wu
2015-05-27 4:05 ` [v8 2/9] iommu: dmar: Extend struct irte for VT-d Posted-Interrupts Feng Wu
2015-05-27 4:05 ` [v8 3/9] iommu, x86: Implement irq_set_vcpu_affinity for intel_ir_chip Feng Wu
2015-06-02 13:59 ` Thomas Gleixner [this message]
2015-06-03 1:05 ` Wu, Feng
2015-05-27 4:05 ` [v8 4/9] iommu, x86: Save the mode (posted or remapped) of an IRTE Feng Wu
2015-05-27 4:05 ` [v8 5/9] iommu, x86: No need to migrating irq for VT-d Posted-Interrupts Feng Wu
2015-05-27 4:05 ` [v8 6/9] iommu, x86: Add cap_pi_support() to detect VT-d PI capability Feng Wu
2015-05-27 4:05 ` [v8 7/9] iommu, x86: Setup Posted-Interrupts capability for Intel iommu Feng Wu
2015-05-27 4:05 ` [v8 8/9] iommu, x86: define irq_remapping_cap() Feng Wu
2015-05-27 4:05 ` [v8 9/9] iommu, x86: Properly handler PI for IOMMU hotplug Feng Wu
2015-06-01 2:18 ` [v8 0/9] Add VT-d Posted-Interrupts support - IOMMU part Wu, Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1506021501070.3786@nanos \
--to=tglx@linutronix.de \
--cc=dwmw2@infradead.org \
--cc=feng.wu@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jiang.liu@linux.intel.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®