From: Thomas Gleixner <tglx@linutronix.de>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
John Stultz <john.stultz@linaro.org>,
heenasirwani@gmail.com, pang.xunlei@linaro.org,
LKML <linux-kernel@vger.kernel.org>,
y2038@lists.linaro.org
Subject: Re: [PATCH v4 02/25] timekeeping:Introduce the current_kernel_time64() function with timespec64 type
Date: Tue, 2 Jun 2015 21:19:44 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1506021734000.20347@nanos> (raw)
In-Reply-To: <1433159393-4629-1-git-send-email-baolin.wang@linaro.org>
On Mon, 1 Jun 2015, Baolin Wang wrote:
Subject line is horrible again.
"timekeeping: Introduce current_kernel_time64()"
Is precise and sufficient.
> This patch adds current_kernel_time64() function with timespec64 type,
> and makes current_kernel_time() 'static inline' and moves it to timekeeping.h
> file.
Again, you describe WHAT the patch is doing first and clutter the
changelog with completely irrelevant information.
> It is convenient for user to get the current kernel time with timespec64 type,
What's conveniant about it?
> and delete the current_kernel_time() function easily in timekeeping.h file. That
> is ready for 2038 when get the current time.
This makes no sense at all.
Again you should describe WHY current_kernel_time() must be replaced.
Thanks,
tglx
prev parent reply other threads:[~2015-06-02 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 11:49 Baolin Wang
2015-06-02 19:19 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1506021734000.20347@nanos \
--to=tglx@linutronix.de \
--cc=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=heenasirwani@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pang.xunlei@linaro.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®