mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, y2038@lists.linaro.org
Subject: Re: [PATCH v4 06/25] time/posix-timers:Introduce {get,put}_timespec and {get,put}_itimerspec
Date: Tue, 2 Jun 2015 21:20:08 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1506021808420.20347@nanos> (raw)
In-Reply-To: <1433159708-4780-1-git-send-email-baolin.wang@linaro.org>

On Mon, 1 Jun 2015, Baolin Wang wrote:

> These are new helper functions that convert between a user timespec/
> itimerspec and a kernel timespec64/itimerspec64 structure.

These are not functions, these are macros.
 
> These macros can change the types underneath from both ends and it
> will work efficiently on both 32-bit and 64-bit that can avoid the
> CONFIG_64BIT macro in syscall functions, and also it can make the
> syscall functions more simple.

Lots of useless blurb which fails to explain WHY this works and WHY
this magically converts the types.

And you fail to mention WHY dropping type safety is a good choice and
WHY dropping the might_fault() check is a proper thing to do.

I also doubt the efficiency part as you replace a linear
copy_to_user() with four seperate ones for an itimerspec.
  
This can be done proper with typesafe inline helpers, if you want to
spare the ifdef in the syscall implementation.

Thanks,

	tglx

  reply	other threads:[~2015-06-02 19:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01 11:55 Baolin Wang
2015-06-02 19:20 ` Thomas Gleixner [this message]
2015-06-04 15:04   ` [Y2038] [PATCH v4 06/25] time/posix-timers:Introduce {get, put}_timespec and {get, put}_itimerspec Arnd Bergmann
2015-06-05  9:59     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1506021808420.20347@nanos \
    --to=tglx@linutronix.de \
    --cc=arnd@arndb.de \
    --cc=baolin.wang@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®