From: Thomas Gleixner <tglx@linutronix.de>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: arnd@arndb.de, john.stultz@linaro.org, heenasirwani@gmail.com,
pang.xunlei@linaro.org, peterz@infradead.org,
rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org,
y2038@lists.linaro.org
Subject: Re: [PATCH v4 17/25] timekeeping:Introduce the timekeeping_clocktai() function with timespec64 type
Date: Tue, 2 Jun 2015 21:20:37 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1506022110400.20347@nanos> (raw)
In-Reply-To: <1433159935-5178-1-git-send-email-baolin.wang@linaro.org>
On Mon, 1 Jun 2015, Baolin Wang wrote:
> Subject: timekeeping:Introduce the timekeeping_clocktai() function with timespec64 type
You are not introducing anything new. You change the implementation.
> This patch converts the timespec type to timespec64 type for
> timekeeping_clocktai() function which is used only in the
> posix-timers.c file, that makes it ready for 2038 issue.
>
> And remove the declaration of timekeeping_clocktai() in
> kernel/time/timekeeping.h file, cause nothing uses that
> declaration now, and it would conflict with the inline
> definition in the include/linux/timekeeping.h file.
>
> Also introduce the clock_get64 callback pointer for the k_clock
> structure, and convert the timespec type to timespec64 type for
> the posix_get_tai() function.
Stop explaining WHAT your patches are doing.
Thanks,
tglx
prev parent reply other threads:[~2015-06-02 19:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 11:58 Baolin Wang
2015-06-02 19:20 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1506022110400.20347@nanos \
--to=tglx@linutronix.de \
--cc=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=heenasirwani@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pang.xunlei@linaro.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®