From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751414AbbFFJnf (ORCPT ); Sat, 6 Jun 2015 05:43:35 -0400 Received: from www.linutronix.de ([62.245.132.108]:37739 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750736AbbFFJn0 (ORCPT ); Sat, 6 Jun 2015 05:43:26 -0400 Date: Sat, 6 Jun 2015 11:43:25 +0200 (CEST) From: Thomas Gleixner To: Vikas Shivappa cc: linux-kernel@vger.kernel.org, vikas.shivappa@intel.com, x86@kernel.org, hpa@zytor.com, mingo@kernel.org, tj@kernel.org, peterz@infradead.org, matt.fleming@intel.com, will.auld@intel.com, kanaka.d.juvva@intel.com Subject: Re: [PATCH 08/10] x86/intel_rdt: Implement scheduling support for Intel RDT In-Reply-To: <1433462497-27087-9-git-send-email-vikas.shivappa@linux.intel.com> Message-ID: References: <1433462497-27087-1-git-send-email-vikas.shivappa@linux.intel.com> <1433462497-27087-9-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Jun 2015, Vikas Shivappa wrote: > +static inline void intel_rdt_sched_in(void) > +{ > + if (static_key_false(&rdt_enable_key)) > + __intel_rdt_sched_in(); So if the enable_key is FALSE we call the RDT stuff? I might be missing something important, but this does not make any sense and I have to ask how that whole stuff has been tested. > /* > * Protects cache_cgroups and cqm_rmid_free_lru and cqm_rmid_limbo_lru. > @@ -403,8 +384,8 @@ static void __intel_cqm_event_count(void *info); > static u32 intel_cqm_xchg_rmid(struct perf_event *group, u32 rmid) > { > struct perf_event *event; > - struct list_head *head = &group->hw.cqm_group_entry; > u32 old_rmid = group->hw.cqm_rmid; > + struct list_head *head = &group->hw.cqm_group_entry; And this change is necessary because? Thanks, tglx