From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754245AbbFPMGW (ORCPT ); Tue, 16 Jun 2015 08:06:22 -0400 Received: from www.linutronix.de ([62.245.132.108]:44438 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751655AbbFPMGM (ORCPT ); Tue, 16 Jun 2015 08:06:12 -0400 Date: Tue, 16 Jun 2015 14:06:00 +0200 (CEST) From: Thomas Gleixner To: Andi Kleen cc: peterz@infradead.org, eranian@google.com, linux-kernel@vger.kernel.org, kan.liang@intel.com, Andi Kleen Subject: Re: [PATCH 3/3] x86, perf, uncore: Don't make MSR uncore depend on PCI uncore In-Reply-To: <1434347862-28490-3-git-send-email-andi@firstfloor.org> Message-ID: References: <1434347862-28490-1-git-send-email-andi@firstfloor.org> <1434347862-28490-3-git-send-email-andi@firstfloor.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 14 Jun 2015, Andi Kleen wrote: > @@ -1287,27 +1289,17 @@ static void __init uncore_cpumask_init(void) > > static int __init intel_uncore_init(void) > { > - int ret; > - > if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL) > return -ENODEV; > > if (cpu_has_hypervisor) > return -ENODEV; > > - ret = uncore_pci_init(); > - if (ret) > - goto fail; > - ret = uncore_cpu_init(); > - if (ret) { > - uncore_pci_exit(); > - goto fail; > - } > + uncore_pci_init(); > + uncore_cpu_init(); > uncore_cpumask_init(); So, even if the cpu does not support that, we install a completely useless cpu notifier and invoke equally pointless init code on all cores. Sigh, tglx