mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ashley Lai <ashley@ashleylai.com>
To: "Hon Ching(Vicky) Lo" <honclo@linux.vnet.ibm.com>
Cc: tpmdd-devel@lists.sourceforge.net,
	Peter Huewe <PeterHuewe@gmx.de>,
	Ashley Lai <ashley@ashleylai.com>,
	Vicky Lo <honclo2014@gmail.com>,
	linux-kernel@vger.kernel.org,
	Joy Latten <jmlatten@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 1/2] vTPM: support little endian guests
Date: Tue, 16 Jun 2015 20:17:56 -0500 (CDT)	[thread overview]
Message-ID: <alpine.DEB.2.11.1506161959240.23568@ant> (raw)
In-Reply-To: <1433901293-29352-1-git-send-email-honclo@linux.vnet.ibm.com>

Just a small comment otherwise it looks good.

On Tue, 9 Jun 2015, Hon Ching(Vicky) Lo wrote:
> 	case NONHOST_INFO:
> -		name = tcpa_event_type_strings[event->event_type];
> +		name =
> +		    tcpa_event_type_strings[do_endian_conversion
> +					    (event->event_type)];
Not being picky but if it does not exceed 80 characters it looks better
to join the line above.
                name = tcpa_event_type_strings[do_endian_conversion
                                               (event->event_type)];

> 		case POST_CONTENTS:
> -			name = tcpa_pc_event_id_strings[pc_event->event_id];
> +			name =
> +			    tcpa_pc_event_id_strings[do_endian_conversion
> +						     (pc_event->event_id)];
Same as above.

Thanks,
--Ashley Lai

  parent reply	other threads:[~2015-06-17  1:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10  1:54 Hon Ching(Vicky) Lo
2015-06-10  1:54 ` [PATCH v2 2/2] TPM: remove unnecessary little endian conversion Hon Ching(Vicky) Lo
2015-06-17  1:20   ` Ashley Lai
2015-06-17  1:17 ` Ashley Lai [this message]
2015-06-17 21:18   ` [PATCH v2 1/2] vTPM: support little endian guests Hon Ching (Vicky) Lo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1506161959240.23568@ant \
    --to=ashley@ashleylai.com \
    --cc=PeterHuewe@gmx.de \
    --cc=honclo2014@gmail.com \
    --cc=honclo@linux.vnet.ibm.com \
    --cc=jmlatten@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tpmdd-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®