From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752811AbbFRW6h (ORCPT ); Thu, 18 Jun 2015 18:58:37 -0400 Received: from www.linutronix.de ([62.245.132.108]:55865 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752105AbbFRW6H (ORCPT ); Thu, 18 Jun 2015 18:58:07 -0400 Date: Fri, 19 Jun 2015 00:57:58 +0200 (CEST) From: Thomas Gleixner To: Andi Kleen cc: Andi Kleen , peterz@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] x86, perf, uncore: Don't make MSR uncore depend on PCI uncore In-Reply-To: <20150618224828.GP25760@tassilo.jf.intel.com> Message-ID: References: <1434660362-4083-1-git-send-email-andi@firstfloor.org> <1434660362-4083-4-git-send-email-andi@firstfloor.org> <20150618224828.GP25760@tassilo.jf.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Jun 2015, Andi Kleen wrote: > > One possible solution is to split the initcall and have one > > for uncore_pci and one for uncode_msr, but that does not work well if > > you want to make it a module. > > > > But we should at least have some indication, what worked and what went > > wrong instead of unconditionally returning success. > > Nobody uses the return value for builtin drivers (short of one > debug printk). Which is a valuable tool to figure out WHY stuff does not work, which you broke for a particular case. > It would not load the module, but right now we don't have a module. Though you keep the exit function around for making this modular. So your argumentation does not make any sense at all. Make it sloppy first, so it's more work to convert it to a module. > Generally it's a bad idea to print something when a probe doesn't work, > as that just leads to lots of dmesg spam for large monolithic kernels. Generally it's bad to just hack stuff into submission and leave the mess created for others to clean up. You've been told that a gazillion times in the past, and I tell it another time, even if I realized long ago, that you are completely advisory resistant. Thanks, tglx