From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932394AbbFWIZu (ORCPT ); Tue, 23 Jun 2015 04:25:50 -0400 Received: from www.linutronix.de ([62.245.132.108]:39241 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753509AbbFWIZn (ORCPT ); Tue, 23 Jun 2015 04:25:43 -0400 Date: Tue, 23 Jun 2015 10:25:14 +0200 (CEST) From: Thomas Gleixner To: Ankit Gupta cc: rostedt@goodmis.org, mingo@redhat.com, agross@codeaurora.org, davem@davemloft.net, rdunlap@infradead.org, standby24x7@gmail.com, sboyd@codeaurora.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gavidov@codeaurora.org, sdharia@codeaurora.org, linux-arm-msm@vger.kernel.org, mlocke@codeaurora.org Subject: Re: [PATCH v2] trace/events: add chip name and hwirq to irq entry tracepoint In-Reply-To: <1435014310-2080-1-git-send-email-ankgupta@codeaurora.org> Message-ID: References: <1435014310-2080-1-git-send-email-ankgupta@codeaurora.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Jun 2015, Ankit Gupta wrote: > Add chip name and hw-irq number to the trace_irq_handler_entry() > tracepoint. When tracing interrupt events the chip-name and hw-irq > numbers are stable and known in advance. This makes them a better > choice as a filtering criteria for the trace buffer dump. On the > flipside, the os-irq numbers are dynamically allocated which makes > them difficult to use for the same purpose. > > Dump messages will look like: > ...irq_handler_entry: irq=22 name=msm_serial0 domain=GIC hwirq=140 I can't see the domain name being captured/printed in the code below. > - TP_printk("irq=%d name=%s", __entry->irq, __get_str(name)) > + TP_printk("irq=%d name=%s chip_name=%s hwirq=%ld", __entry->irq, > + __get_str(name), show_chip_name(__entry->irq), > + show_hwirq(__entry->irq)) > ); Thanks, tglx