From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751575AbbFYO6L (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Jun 2015 10:58:11 -0400
Received: from www.linutronix.de ([62.245.132.108]:48772 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751731AbbFYO6E (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Jun 2015 10:58:04 -0400
Date: Thu, 25 Jun 2015 16:57:59 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
cc: devel@linuxdriverproject.org, "K. Y. Srinivasan" <kys@microsoft.com>,
        linux-kernel@vger.kernel.org, Dexuan Cui <decui@microsoft.com>,
        Ingo Molnar <mingo@kernel.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        =?ISO-8859-2?Q?Radim_Kr=E8m=E1=F8?= <rkrcmar@redhat.com>,
        gregkh@linuxfoundation.org
Subject: Re: [PATCH v5 1/2] cpu-hotplug: export
 cpu_hotplug_enable/cpu_hotplug_disable
In-Reply-To: <1435240249-8893-2-git-send-email-vkuznets@redhat.com>
Message-ID: <alpine.DEB.2.11.1506251652300.4037@nanos>
References: <1435240249-8893-1-git-send-email-vkuznets@redhat.com> <1435240249-8893-2-git-send-email-vkuznets@redhat.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 25 Jun 2015, Vitaly Kuznetsov wrote:

> Loaded Hyper-V module will use these functions to disable CPU hotplug
> under certain circumstances. Convert cpu_hotplug_disabled to a counter
> (protected by cpu_add_remove_lock) to support e.g. disable -> disable ->
> enable call sequences.

This changelog including the subject line still sucks.

Q: How is the counter change related subject line?
A: Not at all.

Q: Why do we need to change this to a counter?
A: Because

Q: What problem is being solved?
A: Dunno

Q: Why do we need the export?
A: HyperV having certain circumstances

Summary: The changelog is useless

The patch wants to be split in two parts:

1) Make the counter change and explain why the current mode is not
   sufficient and what kind of problem can be solved

2) Export the functions with a proper explanation why.

Thanks,

	tglx