From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756893AbbGGL4L (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Jul 2015 07:56:11 -0400
Received: from www.linutronix.de ([62.245.132.108]:60034 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756516AbbGGL4C (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Jul 2015 07:56:02 -0400
Date: Tue, 7 Jul 2015 13:55:55 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Sudeep Holla <sudeep.holla@arm.com>
cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Preeti U Murthy <preeti@linux.vnet.ibm.com>,
        Suzuki Poulose <Suzuki.Poulose@arm.com>,
        Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
        Catalin Marinas <Catalin.Marinas@arm.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [patch 1/2] tick/broadcast: Prevent deep idle states if no
 broadcast device available
In-Reply-To: <559BB736.4000103@arm.com>
Message-ID: <alpine.DEB.2.11.1507071354470.3916@nanos>
References: <20150705205032.103910828@linutronix.de> <20150705205221.724282507@linutronix.de> <559A9A2B.2030705@arm.com> <alpine.DEB.2.11.1507061712590.3916@nanos> <559AA256.5040305@arm.com> <alpine.DEB.2.11.1507061750170.3916@nanos> <559AAC73.6010105@arm.com>
 <alpine.DEB.2.11.1507061838160.3916@nanos> <559AC1A5.901@arm.com> <alpine.DEB.2.11.1507062156040.3916@nanos> <alpine.DEB.2.11.1507070929360.3916@nanos> <559BB736.4000103@arm.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 7 Jul 2015, Sudeep Holla wrote:
> Yes I tested this patch for all the combinations I had mentioned in my
> earlier email. Everything works as expected. Thanks a lot for the
> patience. Please feel free to add:
> 
> Tested-by: Sudeep Holla <sudeep.holla@arm.com>
> 
> >   {
> > Index: tip/kernel/time/tick-broadcast.c
> > ===================================================================
> > --- tip.orig/kernel/time/tick-broadcast.c
> > +++ tip/kernel/time/tick-broadcast.c
> 
> > @@ -938,6 +972,16 @@ bool tick_broadcast_oneshot_available(vo
> >   	return bc ? bc->features & CLOCK_EVT_FEAT_ONESHOT : false;
> >   }
> > 
> > +#else
> > +int __tick_broadcast_oneshot_control(enum tick_broadcast_state state)
> > +{
> > +	struct clock_event_device *bc = tick_broadcast_device.evtdev;
> > +
> > +	if (!bc || (bc->features & CLOCK_EVT_FEAT_HRTIMER)
> 
> missing ')' at the end in the above statement

Indeed. Did not compile that combo.
 
Thanks a lot for testing all the combos!!!

       tglx