From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934097AbbGHJuJ (ORCPT ); Wed, 8 Jul 2015 05:50:09 -0400 Received: from www.linutronix.de ([62.245.132.108]:36226 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932964AbbGHJuG (ORCPT ); Wed, 8 Jul 2015 05:50:06 -0400 Date: Wed, 8 Jul 2015 11:49:58 +0200 (CEST) From: Thomas Gleixner To: Andy Shevchenko cc: "David E. Box" , x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH v1 1/4] iosf_mbi: check result for all calls of debugfs API In-Reply-To: <1436347973-50436-2-git-send-email-andriy.shevchenko@linux.intel.com> Message-ID: References: <1436347973-50436-1-git-send-email-andriy.shevchenko@linux.intel.com> <1436347973-50436-2-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Jul 2015, Andy Shevchenko wrote: > While here, replase IS_ERR_OR_NULL(x) to just !x since first one does the job > for us. While here? The first one? What? Can you please provide a sensible changelog? Thanks, tglx