From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934252AbbGHJwt (ORCPT ); Wed, 8 Jul 2015 05:52:49 -0400 Received: from www.linutronix.de ([62.245.132.108]:36246 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758236AbbGHJwq (ORCPT ); Wed, 8 Jul 2015 05:52:46 -0400 Date: Wed, 8 Jul 2015 11:52:38 +0200 (CEST) From: Thomas Gleixner To: Ingo Molnar cc: Andy Shevchenko , "David E. Box" , x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH v1 0/4] iosf_mbi: clean up In-Reply-To: <20150708093641.GA1989@gmail.com> Message-ID: References: <1436347973-50436-1-git-send-email-andriy.shevchenko@linux.intel.com> <20150708093641.GA1989@gmail.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Jul 2015, Ingo Molnar wrote: > * Andy Shevchenko wrote: > > > There are few patches to clean up (with small fixes) iosf_mbi driver along with > > extension it to cover Intel Tangier. > > > > Andy Shevchenko (4): > > iosf_mbi: check result for all calls of debugfs API > > iosf_mbi: pci_dev_put() is NULL-proof > > iosf_mbi: group global variables > > iosf_mbi: append Intel Tangier ID > > > > arch/x86/include/asm/iosf_mbi.h | 8 ++++---- > > arch/x86/kernel/iosf_mbi.c | 31 +++++++++++++++---------------- > > 2 files changed, 19 insertions(+), 20 deletions(-) > > Could you please also move it from arch/x86/kernel/ to > arch/x86/platform/[intel-quark?] while at it? > > arch/x86/kernel/ is the wrong place for this driver. Aside of that the patch prefixes should be: x86/platform/iosf_mbi: or something like that. Thanks, tglx