From: Thomas Gleixner <tglx@linutronix.de>
To: Alban Bedel <albeu@free.fr>
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>,
Andrew Bresticker <abrestic@chromium.org>,
Qais Yousef <qais.yousef@imgtec.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: ath79: irq: Remove the include of drivers/irqchip/irqchip.h
Date: Sat, 11 Jul 2015 22:36:26 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1507112233280.20072@nanos> (raw)
In-Reply-To: <1436379071-31574-1-git-send-email-albeu@free.fr>
On Wed, 8 Jul 2015, Alban Bedel wrote:
> We shouldn't include irqchip.h from outside of the drivers/irqchip
> directory. The irq driver should idealy be there, however this not
> trivial at the moment. We still need to support platforms without DT
> support and the interface to the DDR controller still use a custom
> arch specific API.
>
> For now just redefine the IRQCHIP_DECLARE macro to avoid the cross
> tree include.
The macro has been moved to linux/irqchip.h.
But even if it would still be in drivers/irqchip such a redefine is
even worse than the ../../... include. And the proper solution from
the very beginning would have been to move the macro to the global
header instead of this horrible include.
Sigh,
tglx
prev parent reply other threads:[~2015-07-11 20:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 18:11 Alban Bedel
2015-07-08 18:28 ` Jonas Gorski
2015-07-11 20:36 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1507112233280.20072@nanos \
--to=tglx@linutronix.de \
--cc=abrestic@chromium.org \
--cc=albeu@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=qais.yousef@imgtec.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®