From: Thomas Gleixner <tglx@linutronix.de>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Chris Metcalf <cmetcalf@ezchip.com>,
Don Zickus <dzickus@redhat.com>,
Ulrich Obergfell <uobergfe@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/4] smpboot: Make cleanup to mirror setup
Date: Sun, 12 Jul 2015 08:08:21 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1507120807570.20072@nanos> (raw)
In-Reply-To: <1436629952-17291-3-git-send-email-fweisbec@gmail.com>
On Sat, 11 Jul 2015, Frederic Weisbecker wrote:
> --- a/kernel/smpboot.c
> +++ b/kernel/smpboot.c
> @@ -113,7 +113,8 @@ static int smpboot_thread_fn(void *data)
> if (kthread_should_stop()) {
> __set_current_state(TASK_RUNNING);
> preempt_enable();
> - if (ht->cleanup)
> + /* cleanup must mirror setup */
> + if (ht->cleanup && td->status != HP_THREAD_NONE)
> ht->cleanup(td->cpu, cpu_online(td->cpu));
> kfree(td);
> return 0;
> @@ -259,15 +260,6 @@ static void smpboot_destroy_threads(struct smp_hotplug_thread *ht)
> {
> unsigned int cpu;
>
> - /* Unpark any threads that were voluntarily parked. */
> - for_each_cpu_not(cpu, ht->cpumask) {
> - if (cpu_online(cpu)) {
> - struct task_struct *tsk = *per_cpu_ptr(ht->store, cpu);
> - if (tsk)
> - kthread_unpark(tsk);
> - }
> - }
> -
> /* We need to destroy also the parked threads of offline cpus */
> for_each_possible_cpu(cpu) {
> struct task_struct *tsk = *per_cpu_ptr(ht->store, cpu);
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2015-07-12 6:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-11 15:52 [PATCH 0/4] smpboot/watchdog: Fixes and cleanups v2 Frederic Weisbecker
2015-07-11 15:52 ` [PATCH 1/4] smpboot: Fix memory leak on error handling Frederic Weisbecker
2015-07-12 6:07 ` Thomas Gleixner
2015-07-11 15:52 ` [PATCH 2/4] smpboot: Make cleanup to mirror setup Frederic Weisbecker
2015-07-12 6:08 ` Thomas Gleixner [this message]
2015-07-11 15:52 ` [PATCH 3/4] smpboot: Allow to pass the cpumask on per-cpu thread registration Frederic Weisbecker
2015-07-12 6:10 ` Thomas Gleixner
2015-07-11 15:52 ` [PATCH 4/4] watchdog: Simplify housekeeping affinity with the appropriate mask Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2015-07-09 15:16 [PATCH 0/4] smpboot/watchdog: Fixes and cleanups Frederic Weisbecker
2015-07-09 15:16 ` [PATCH 2/4] smpboot: Make cleanup to mirror setup Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1507120807570.20072@nanos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=cmetcalf@ezchip.com \
--cc=dzickus@redhat.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®