From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752868AbbGMVHT (ORCPT ); Mon, 13 Jul 2015 17:07:19 -0400 Received: from www.linutronix.de ([62.245.132.108]:56524 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752637AbbGMVHR (ORCPT ); Mon, 13 Jul 2015 17:07:17 -0400 Date: Mon, 13 Jul 2015 23:07:08 +0200 (CEST) From: Thomas Gleixner To: Julia Lawall cc: LKML , Ralf Baechle , Jiang Liu , linux-mips@linux-mips.org, Russell King Subject: Re: [patch 04/12] MIPS/pci-rt3883: Consolidate chained IRQ handler install/remove In-Reply-To: Message-ID: References: <20150713200602.799079101@linutronix.de> <20150713200714.765131309@linutronix.de> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Jul 2015, Julia Lawall wrote: > On Mon, 13 Jul 2015, Thomas Gleixner wrote: > > > Chained irq handlers usually set up handler data as well. We now have > > a function to set both under irq_desc->lock. Replace the two calls > > with one. > > Are the original calls remaining? If so, should there be a semantic patch > in the kernel to check for this, in case people ut the two calls in teh > future. irq_set_handler_data() can be used in a different context as well. irq_set_chained_handler() has to stay for now, but we probably can replace it with irq_set_chained_handler_and_data(irq, handler, NULL). Have not yet done the analysis. But yes, a semantic check for this would be nice. Thanks, tglx