From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755949AbbGTUoZ (ORCPT ); Mon, 20 Jul 2015 16:44:25 -0400 Received: from www.linutronix.de ([62.245.132.108]:57373 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024AbbGTUoY (ORCPT ); Mon, 20 Jul 2015 16:44:24 -0400 Date: Mon, 20 Jul 2015 22:44:08 +0200 (CEST) From: Thomas Gleixner To: Felipe Balbi cc: Tony Lindgren , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH RESEND] irqchip: omap-intc: improve IRQ handler In-Reply-To: <1437410759-4945-1-git-send-email-balbi@ti.com> Message-ID: References: <1437410759-4945-1-git-send-email-balbi@ti.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Jul 2015, Felipe Balbi wrote: > + irqnr = intc_readl(INTC_SIR); > + irqnr &= ACTIVEIRQ_MASK; > + WARN(!irqnr, "Spurious IRQ ?\n"); Shouldn't that be WARN_ONCE? Thanks, tglx