mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Pan Xinhui <xinhuix.pan@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	mingo@redhat.com, hpa@zytor.com, x86@kernel.org, bp@suse.de,
	toshi.kani@hp.com, jgross@suse.com, mcgrof@suse.com,
	"mnipxh@163.com" <mnipxh@163.com>,
	"yanmin_zhang@linux.intel.com" <yanmin_zhang@linux.intel.com>
Subject: Re: [PATCH V2] x86/mm/pat: Do a small optimization and fix in reserve_memtype
Date: Tue, 21 Jul 2015 17:23:16 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1507211722280.18576@nanos> (raw)
In-Reply-To: <55AE0233.3080102@intel.com>

On Tue, 21 Jul 2015, Pan Xinhui wrote:
> So *ret_type might be set to found_type(match->type),
> 
> The call train is deep, it took me long time to review them.
> As actual_type != new->type is possible, we need save new->type to actual_type.

Fair enough. But that wants to have a comment in the code as any
casual reader will trip over this.

Thanks,

	tglx

      reply	other threads:[~2015-07-21 15:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-21  8:02 Pan Xinhui
2015-07-21  8:10 ` Thomas Gleixner
2015-07-21  8:26   ` Pan Xinhui
2015-07-21 15:23     ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1507211722280.18576@nanos \
    --to=tglx@linutronix.de \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@suse.com \
    --cc=mingo@redhat.com \
    --cc=mnipxh@163.com \
    --cc=toshi.kani@hp.com \
    --cc=x86@kernel.org \
    --cc=xinhuix.pan@intel.com \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®