From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754968AbbGZJxU (ORCPT ); Sun, 26 Jul 2015 05:53:20 -0400 Received: from www.linutronix.de ([62.245.132.108]:53074 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752992AbbGZJxS (ORCPT ); Sun, 26 Jul 2015 05:53:18 -0400 Date: Sun, 26 Jul 2015 11:52:52 +0200 (CEST) From: Thomas Gleixner To: Eric Anholt cc: linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Warren , Lee Jones , devicetree@vger.kernel.org, Jason Cooper , Andrea Merello Subject: Re: [PATCH v2 4/4] irqchip: Add bcm2836 interrupt controller for Raspberry Pi 2. In-Reply-To: <1436837718-956-5-git-send-email-eric@anholt.net> Message-ID: References: <1436837718-956-1-git-send-email-eric@anholt.net> <1436837718-956-5-git-send-email-eric@anholt.net> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Jul 2015, Eric Anholt wrote: > +static void > +bcm2836_arm_irqchip_smp_init(void) > +{ > +#ifdef CONFIG_SMP > + int i; > + > + /* unmask IPIs */ > + for_each_possible_cpu(i) { > + bcm2836_arm_irqchip_unmask_per_cpu_irq( > + LOCAL_MAILBOX_INT_CONTROL0, 0, i); Do you really want to enable these interrupts on all possible cpus? Why so? Shouldn't that be done at the point where a hotplugged CPU is starting ? Thanks, tglx