From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
x86@kernel.org
Subject: Re: [PATCH v3 0/3] x86/pci/intel-mid-pci: fix to get eMMC detected
Date: Wed, 29 Jul 2015 21:33:27 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1507292128330.3825@nanos> (raw)
In-Reply-To: <1438161409-4671-1-git-send-email-andriy.shevchenko@linux.intel.com>
On Wed, 29 Jul 2015, Andy Shevchenko wrote:
> On Intel Edison we have an interesting implementation of x86 platform without
> legacy PIC and with specific PCI. There are devices which are not using
> interrupt line 0, but have it assigned in the PCI configuration. By default
> first come gets it, though the first eMMC host controller is the actual user
> for IRQ0.
>
> So, this series provides a quirk (patch 1) to resolve the issue, a small fix of
> error code (patch 2), and a sparse warning fix (patch 3).
>
> Changelog v3:
> - address Thomas' comments
> - massage changelog (what Thomas proposed)
>
> Andy Shevchenko (3):
> x86/pci/intel_mid_pci: work around for IRQ0 assignment
> x86/pci/intel_mid_pci: propagate actual return code
> x86/pci/intel_mid_pci: fix a sparse warning
I've picked them up. If you get the tip-bot mails, you might notice a
few edits on the changelogs.
- Sentence starts with an upper case letter.
- You cannot fix a sparse warning.
- "This patch does ...." is just horrible. When one reads a patch
he already knows that it is a patch.
Please avoid these things in the future.
Thanks,
tglx
prev parent reply other threads:[~2015-07-29 19:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 9:16 Andy Shevchenko
2015-07-29 9:16 ` [PATCH v3 1/3] x86/pci/intel_mid_pci: work around for IRQ0 assignment Andy Shevchenko
2015-07-29 19:36 ` [tip:x86/platform] x86/pci/intel_mid_pci: Work " tip-bot for Andy Shevchenko
2015-07-29 9:16 ` [PATCH v3 2/3] x86/pci/intel_mid_pci: propagate actual return code Andy Shevchenko
2015-07-29 19:36 ` [tip:x86/platform] x86/pci/intel_mid_pci: Propagate " tip-bot for Andy Shevchenko
2015-07-29 9:16 ` [PATCH v3 3/3] x86/pci/intel_mid_pci: fix a sparse warning Andy Shevchenko
2015-07-29 19:37 ` [tip:x86/platform] x86/pci/intel_mid_pci: Make intel_mid_pci_ops static tip-bot for Andy Shevchenko
2015-07-29 19:33 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1507292128330.3825@nanos \
--to=tglx@linutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®