mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: yalin wang <yalin.wang2010@gmail.com>
Cc: Neil Horman <nhorman@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Kershner <david.kershner@unisys.com>,
	tj@kernel.org, laijs@cn.fujitsu.com, nacc@linux.vnet.ibm.com,
	mingo@redhat.com, open list <linux-kernel@vger.kernel.org>,
	jes.sorensen@redhat.com, sparmaintainer@unisys.com
Subject: Re: [PATCH v2] kthread: Export kthread functions
Date: Fri, 31 Jul 2015 16:14:14 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1507311610180.3825@nanos> (raw)
In-Reply-To: <alpine.DEB.2.11.1507311019040.3825@nanos>


On Fri, 31 Jul 2015, Thomas Gleixner wrote:

> On Fri, 31 Jul 2015, yalin wang wrote:
> > it is optimised to 2 instructions ,
> > 
> > this is my patch, hope can be merged :
> 
> We are not exposing the internals of kthread management. Period.

And your 'optimization' is completely bogus:

Before your modification:

size kernel/built-in.o

   text	   data	    bss	    dec	    hex	filename
1091514	 141498  341928 1574940  18081c	../build/kernel/built-in.o

After:

   text	   data	    bss	    dec	    hex	filename
1091664  141498  341928 1575090  1808b2	../build/kernel/built-in.o

That's an increase of text size by 150 byte. Interesting optimization.

Thanks,

	tglx



  reply	other threads:[~2015-07-31 14:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-24 22:45 [PATCH] " David Kershner
2015-07-24 23:14 ` Neil Horman
2015-07-25 12:05 ` Richard Weinberger
2015-07-26  0:50   ` Kershner, David A
2015-07-26  8:46   ` Thomas Gleixner
2015-07-27 15:45 ` Ingo Molnar
2015-07-27 15:49   ` Neil Horman
2015-07-27 16:01     ` Kershner, David A
2015-07-28 15:59 ` [PATCH v2] " David Kershner
2015-07-28 21:27   ` Andrew Morton
2015-07-29 10:34     ` Thomas Gleixner
2015-07-30  3:48       ` yalin wang
2015-07-30 12:02         ` Neil Horman
2015-07-31  4:16           ` yalin wang
2015-07-31  8:19             ` Thomas Gleixner
2015-07-31 14:14               ` Thomas Gleixner [this message]
2015-08-01  7:12                 ` yalin wang
2015-08-01  7:20                   ` Thomas Gleixner
2015-08-01 13:32                   ` Neil Horman
2015-08-03  2:23                     ` yalin wang
2015-08-03  2:42                       ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1507311610180.3825@nanos \
    --to=tglx@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=david.kershner@unisys.com \
    --cc=jes.sorensen@redhat.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nacc@linux.vnet.ibm.com \
    --cc=nhorman@redhat.com \
    --cc=sparmaintainer@unisys.com \
    --cc=tj@kernel.org \
    --cc=yalin.wang2010@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®