From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751249AbbHBKWw (ORCPT ); Sun, 2 Aug 2015 06:22:52 -0400 Received: from www.linutronix.de ([62.245.132.108]:57719 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbbHBKWu (ORCPT ); Sun, 2 Aug 2015 06:22:50 -0400 Date: Sun, 2 Aug 2015 12:22:24 +0200 (CEST) From: Thomas Gleixner To: Eric Anholt cc: linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stephen Warren , Lee Jones , devicetree@vger.kernel.org, Jason Cooper Subject: Re: [PATCH] irqchip: bcm2836: Use a CPU notifier enable IPIs. In-Reply-To: <1438027789-1637-1-git-send-email-eric@anholt.net> Message-ID: References: <55B67C81.1010900@gmail.com> <1438027789-1637-1-git-send-email-eric@anholt.net> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Jul 2015, Eric Anholt wrote: > +/* Unmasks the IPI on the CPU wen it's first brought online. */ when > +static int bcm2836_arm_irqchip_cpu_notify(struct notifier_block *nfb, > + unsigned long action, void *hcpu) > +{ > + unsigned int cpu = (unsigned long)hcpu; > + unsigned int int_reg = LOCAL_MAILBOX_INT_CONTROL0; > + unsigned int mailbox = 0; > + > + if (action == CPU_STARTING || action == CPU_STARTING_FROZEN) > + bcm2836_arm_irqchip_unmask_per_cpu_irq(int_reg, mailbox, cpu); Shouldn't you mask the irq on CPU_DYING? Thanks, tglx