From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932737AbbHYTeb (ORCPT ); Tue, 25 Aug 2015 15:34:31 -0400 Received: from www.linutronix.de ([62.245.132.108]:52354 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932072AbbHYTea (ORCPT ); Tue, 25 Aug 2015 15:34:30 -0400 Date: Tue, 25 Aug 2015 21:34:00 +0200 (CEST) From: Thomas Gleixner To: Huang Shijie cc: jiang.liu@linux.intel.com, marc.zyngier@arm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqdomain: remove the confused log In-Reply-To: <1440496131-29192-1-git-send-email-shijie.huang@arm.com> Message-ID: References: <1440496131-29192-1-git-send-email-shijie.huang@arm.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Aug 2015, Huang Shijie wrote: > When the dynamic debug is enabled for irq domain, the kernel will print out: > ------------------------------------------------------ > irqdomain:__irq_domain_add: irq: Added domain (null) > ------------------------------------------------------ > > It does not print out the irq domain's name, since the @domain->name is NULL. > Keep the log here just makes people nervous. Well, it might be NULL in your case, but there are enough cases where its not NULL and the output valuable. Aside of that I don't understand what's making one nervous here. People who enable that debug stuff should know that this can be NULL and just deal with it. If they get nervous about it they probably should not try to debug that code in the first place. Thanks, tglx