From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756475AbbHZHuq (ORCPT ); Wed, 26 Aug 2015 03:50:46 -0400 Received: from www.linutronix.de ([62.245.132.108]:54161 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756289AbbHZHup (ORCPT ); Wed, 26 Aug 2015 03:50:45 -0400 Date: Wed, 26 Aug 2015 09:50:14 +0200 (CEST) From: Thomas Gleixner To: Huang Shijie cc: jiang.liu@linux.intel.com, marc.zyngier@arm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqdomain: remove the confused log In-Reply-To: <20150826013747.GA30900@free64-pc.asiapac.arm.com> Message-ID: References: <1440496131-29192-1-git-send-email-shijie.huang@arm.com> <20150826013747.GA30900@free64-pc.asiapac.arm.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Aug 2015, Huang Shijie wrote: > On Tue, Aug 25, 2015 at 09:34:00PM +0200, Thomas Gleixner wrote: > > On Tue, 25 Aug 2015, Huang Shijie wrote: > > > > > When the dynamic debug is enabled for irq domain, the kernel will print out: > > > ------------------------------------------------------ > > > irqdomain:__irq_domain_add: irq: Added domain (null) > > > ------------------------------------------------------ > > > > > > It does not print out the irq domain's name, since the @domain->name is NULL. > > > Keep the log here just makes people nervous. > > > > Well, it might be NULL in your case, but there are enough cases where > > its not NULL and the output valuable. > In which case ? > > The domain is allocated by kzalloc_node(), so @domain->name is NULL in the function. > The @domain->name is set in other function, such as irq_domain_associate(). Indeed. I misread the patch, sorry. Yes that thing can go. Thanks, tglx