From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756206AbbIAUqU (ORCPT ); Tue, 1 Sep 2015 16:46:20 -0400 Received: from www.linutronix.de ([62.245.132.108]:58275 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755945AbbIAUqQ (ORCPT ); Tue, 1 Sep 2015 16:46:16 -0400 Date: Tue, 1 Sep 2015 22:45:40 +0200 (CEST) From: Thomas Gleixner To: John Stultz cc: =?ISO-8859-15?Q?Nuno_Gon=E7alves?= , LKML , Miroslav Lichvar , dl4mea@yahoo.de, stable Subject: Re: Regression: can't apply frequency offsets above 1000ppm. In-Reply-To: Message-ID: References: User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-593185418-1441140341=:15006" X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-593185418-1441140341=:15006 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 1 Sep 2015, John Stultz wrote: > On Tue, Sep 1, 2015 at 1:25 PM, Thomas Gleixner wrote: > > On Tue, 1 Sep 2015, Nuno Gonçalves wrote: > > > >> There is a regression on the clock system since v3.16-rc5-111-g4396e05 > >> [1], > > > >> [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4396e058c52e167729729cf64ea3dfa229637086 > > > > That commit has absolutely nothing to do with NTP. I fear your bisect > > went down the wrong road somewhere. > > > >> where the clock doesn't apply frequency offsets above about > >> 1000ppm [2]. > > > > This looks pretty familiar. > > > > The issue was introduced with commit 5e5aeb4367b (time: adjtimex: > > Validate the ADJ_FREQUENCY values). That patch was tagged for stable, > > so it got backported. > > > > The fix is in commit 29183a70b0b82 (ntp: Fixup adjtimex freq > > validation on 32-bit systems). That commit was tagged for stable as > > well, but with the extra '#3.19+' limitation. > > > > So in the worst case 5e5aeb4367b hit a stable tree < 3.19, but > > 29183a70b0b82 did not. > > Hrm. So that would be problematic, and I'll have to follow up that > both changes got backported together. > > But I don't think that's the issue here, since the problem supposedly > continues w/ 4.2... Duh, missed that part. Thanks, tglx --8323329-593185418-1441140341=:15006--