From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752740AbbIHUEX (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Sep 2015 16:04:23 -0400
Received: from www.linutronix.de ([62.245.132.108]:49861 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752048AbbIHUEV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Sep 2015 16:04:21 -0400
Date: Tue, 8 Sep 2015 22:03:41 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
cc: Geert Uytterhoeven <geert+renesas@glider.be>,
        Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Magnus Damm <magnus.damm@gmail.com>,
        Linux-sh list <linux-sh@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH 1/2] irqchip: renesas-intc-irqpin: Propagate wake-up
 settings to parent
In-Reply-To: <CAMuHMdVU+ghBGxEw0qrZ611PwO1n808vcBXPEUxemGyJXS1Mjg@mail.gmail.com>
Message-ID: <alpine.DEB.2.11.1509082149250.3854@nanos>
References: <1441731636-17610-1-git-send-email-geert+renesas@glider.be> <1441731636-17610-2-git-send-email-geert+renesas@glider.be> <alpine.DEB.2.11.1509082104330.3854@nanos> <CAMuHMdVU+ghBGxEw0qrZ611PwO1n808vcBXPEUxemGyJXS1Mjg@mail.gmail.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 8 Sep 2015, Geert Uytterhoeven wrote:
> >> --- a/drivers/irqchip/irq-renesas-intc-irqpin.c
> >> +++ b/drivers/irqchip/irq-renesas-intc-irqpin.c
> >> @@ -283,6 +283,9 @@ static int intc_irqpin_irq_set_type(struct irq_data *d, unsigned int type)
> >>  static int intc_irqpin_irq_set_wake(struct irq_data *d, unsigned int on)
> >>  {
> >>       struct intc_irqpin_priv *p = irq_data_get_irq_chip_data(d);
> >> +     int hw_irq = irqd_to_hwirq(d);
> >> +
> >> +     irq_set_irq_wake(p->irq[hw_irq].requested_irq, on);
> >
> > Are you sure that this does not make lockdep unhappy due to lock
> > nesting?
> 
> Actually I did see one lockdep warning, so I'm aware we're probably gonna
> need a similar solution like commit a0a8bcf4670c2c69 ("gpiolib: irqchip:
> use different lockdep class for each gpio irqchip")?
> 
> To be honest, these lockdep warnings aren't helping much here: on embedded
> we typical have several stacked interrupt controllers, so wake-up settings
> have to propagate from the bottom to the top of the stack.

But ignoring them does not help much either, right?
 
> E.g. on sh73a0/kzm9g gpio-keys wake-up goes through 3 interrupt controllers:
> pcf875x -> renesas-intc-irqpin -> gic.

So, yes a seperate locking class for that intc trainwreck is probably
required.

Thanks,

	tglx