From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755301AbbINJpZ (ORCPT ); Mon, 14 Sep 2015 05:45:25 -0400 Received: from www.linutronix.de ([62.245.132.108]:38031 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752227AbbINJpY (ORCPT ); Mon, 14 Sep 2015 05:45:24 -0400 Date: Mon, 14 Sep 2015 11:44:39 +0200 (CEST) From: Thomas Gleixner To: Andi Kleen cc: peterz@infradead.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] x86, perf, uncore: Don't make MSR uncore depend on PCI uncore In-Reply-To: <1441836284-23736-1-git-send-email-andi@firstfloor.org> Message-ID: References: <1441836284-23736-1-git-send-email-andi@firstfloor.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Sep 2015, Andi Kleen wrote: > --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c > +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c > @@ -958,6 +958,8 @@ static void __init uncore_pci_exit(void) > uncore_types_exit(uncore_pci_uncores); > } > } > +module_exit(uncore_pci_exit); > +/* XXX: need exit code for rest of intel_uncore_init too */ That comment makes no sense at all. Other than that: Reviewed-by: Thomas Gleixner