From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752167AbbIOMFc (ORCPT ); Tue, 15 Sep 2015 08:05:32 -0400 Received: from www.linutronix.de ([62.245.132.108]:43083 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751567AbbIOMFa (ORCPT ); Tue, 15 Sep 2015 08:05:30 -0400 Date: Tue, 15 Sep 2015 14:04:49 +0200 (CEST) From: Thomas Gleixner To: Tomasz Nowicki cc: Marc Zyngier , Jiang Liu , Jason Cooper , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lorenzo Pieralisi , Hanjun Guo , Suravee Suthikulpanit , Graeme Gregory , Jake Oshins Subject: Re: [PATCH v3 2/8] genirq: irqdomain: Remove irqdomain dependency on struct device_node In-Reply-To: <55F7F9E2.3070105@linaro.org> Message-ID: References: <1442249047-21182-1-git-send-email-marc.zyngier@arm.com> <1442249047-21182-3-git-send-email-marc.zyngier@arm.com> <55F7F9E2.3070105@linaro.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Sep 2015, Tomasz Nowicki wrote: Can you folks please do proper quoting on reply? It's annoying to scroll down 250+ lines to find TWO lines of reply and then have another 250+ lines for nothing. Here is the real gist of your reply: > On 14.09.2015 18:44, Marc Zyngier wrote: > > -struct irq_domain *__irq_domain_add(struct device_node *of_node, int size, > > +struct irq_domain *__irq_domain_add(void *domain_token, int size, > > irq_hw_number_t hwirq_max, int direct_max, > > const struct irq_domain_ops *ops, > > void *host_data) > > { > > + struct device_node *of_node; > > struct irq_domain *domain; > > > > + of_node = irq_domain_token_to_of_node(domain_token); > > domain = kzalloc_node(sizeof(*domain) + (sizeof(unsigned int) * size), > > GFP_KERNEL, of_node_to_nid(of_node)); > > While we are here, do you think it makes sense to abstract of_node_to_nid as > well? Then we would really remove device_node dependency for irqdomain. 15 lines of useful content versus 500+ lines of useless noise. Thanks, tglx