From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752925AbbIPQxV (ORCPT ); Wed, 16 Sep 2015 12:53:21 -0400 Received: from www.linutronix.de ([62.245.132.108]:49543 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752633AbbIPQxU (ORCPT ); Wed, 16 Sep 2015 12:53:20 -0400 Date: Wed, 16 Sep 2015 18:52:41 +0200 (CEST) From: Thomas Gleixner To: Jisheng Zhang cc: jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com, linux-kernel@vger.kernel.org Subject: Re: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest") In-Reply-To: <20150917003202.498ff83c@xhacker> Message-ID: References: <20150917003202.498ff83c@xhacker> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Sep 2015, Jisheng Zhang wrote: > Hi Marc, > > Commit 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a > guest") causes a regression on Marvell BG4CT SoC. In this SoC, there's only one > GIC, the secondary irq controller is Synopsys DW iCtl: > drivers/irqchip/irq-dw-apb-ictl.c > > So cascading_gic_irq() should return true on Marvell BG4CT SoC, but it returns > false. The logic in cascading_gic_irq() doesn't take cascaded irq controller > which is provided by non-gic controllers. I have a fix pending for this in git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tmp.irq 714665351cc7: irqchip/gic: Use IRQD_FORWARDED_TO_VCPU flag Can you please give that a try? Thanks, tglx