From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754057AbbIQIAS (ORCPT ); Thu, 17 Sep 2015 04:00:18 -0400 Received: from www.linutronix.de ([62.245.132.108]:51588 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753877AbbIQIAQ (ORCPT ); Thu, 17 Sep 2015 04:00:16 -0400 Date: Thu, 17 Sep 2015 09:59:42 +0200 (CEST) From: Thomas Gleixner To: Kohji Okuno cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting In-Reply-To: <1442474027-10839-1-git-send-email-okuno.kohji@jp.panasonic.com> Message-ID: References: <1442474027-10839-1-git-send-email-okuno.kohji@jp.panasonic.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Sep 2015, Kohji Okuno wrote: > If handler and thread_fn have valid function pointers for each > in request_thread_irq(), IRQF_ONESHOT is set unnecessarily in > irq_setup_forces_threading() in case of threadirqs. > As this result, the IRQ handler will not be called. That explanation does not make sense. Which handler is not called? Thanks, tglx