mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Yunhong Jiang <yunhong.jiang@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nohz: make the idle_entrytime/idle_exittime correct
Date: Thu, 17 Sep 2015 23:45:37 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1509172344140.3951@nanos> (raw)
In-Reply-To: <1442445583-10240-1-git-send-email-yunhong.jiang@linux.intel.com>

On Wed, 16 Sep 2015, Yunhong Jiang wrote:

> Currently the idle_entrytime is updated on idle_entry, idle_exit and
> get_cpu_idle/iowait_time_us() with non-NULL parameter. This makes the
> idle_entrytime not the real entrytime anymore. The idle_exittiime is
> updated when exit tickless state, which can be idle tickless or full
> tickless.

If something calls one of the functions then the cpu is not idle. It's
running code.
 
> Change the idle_entrytime to be updated only when enter idle, the
> idle_exittime to be updated only when exit idle. Update
> the get_cpu_idle_iowait_time_us() accordingly.

And the rationale for this change is?

Thanks,

	tglx

  reply	other threads:[~2015-09-17 21:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16 23:19 Yunhong Jiang
2015-09-17 21:45 ` Thomas Gleixner [this message]
2015-09-18 18:42   ` Yunhong Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1509172344140.3951@nanos \
    --to=tglx@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yunhong.jiang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®