From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752395AbbIRSoT (ORCPT ); Fri, 18 Sep 2015 14:44:19 -0400 Received: from www.linutronix.de ([62.245.132.108]:59212 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbbIRSoR (ORCPT ); Fri, 18 Sep 2015 14:44:17 -0400 Date: Fri, 18 Sep 2015 20:43:36 +0200 (CEST) From: Thomas Gleixner To: Paolo Bonzini cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Ingo Molnar , "H. Peter Anvin" , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Jiang Liu , Joerg Roedel , Feng Wu Subject: Re: [PATCH] irq_remapping: move structs outside #ifdef In-Reply-To: <1442592379-12021-1-git-send-email-pbonzini@redhat.com> Message-ID: References: <1442592379-12021-1-git-send-email-pbonzini@redhat.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Sep 2015, Paolo Bonzini wrote: > This is friendlier to clients of the code, who are going to prepare > vcpu_data structs unconditionally, even if CONFIG_IRQ_REMAP is not > defined. > > Signed-off-by: Paolo Bonzini Reviewed-by: Thomas Gleixner > --- > Please ack, I'd like to include it in the 4.4 pull request. > > arch/x86/include/asm/irq_remapping.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/x86/include/asm/irq_remapping.h b/arch/x86/include/asm/irq_remapping.h > index 046c7fb1ca43..a210eba2727c 100644 > --- a/arch/x86/include/asm/irq_remapping.h > +++ b/arch/x86/include/asm/irq_remapping.h > @@ -33,6 +33,11 @@ enum irq_remap_cap { > IRQ_POSTING_CAP = 0, > }; > > +struct vcpu_data { > + u64 pi_desc_addr; /* Physical address of PI Descriptor */ > + u32 vector; /* Guest vector of the interrupt */ > +}; > + > #ifdef CONFIG_IRQ_REMAP > > extern bool irq_remapping_cap(enum irq_remap_cap cap); > @@ -58,11 +63,6 @@ static inline struct irq_domain *arch_get_ir_parent_domain(void) > return x86_vector_domain; > } > > -struct vcpu_data { > - u64 pi_desc_addr; /* Physical address of PI Descriptor */ > - u32 vector; /* Guest vector of the interrupt */ > -}; > - > #else /* CONFIG_IRQ_REMAP */ > > static inline bool irq_remapping_cap(enum irq_remap_cap cap) { return 0; } > -- > 1.8.3.1 > >