From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932958AbbIUQwS (ORCPT ); Mon, 21 Sep 2015 12:52:18 -0400 Received: from www.linutronix.de ([62.245.132.108]:37307 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932395AbbIUQwP (ORCPT ); Mon, 21 Sep 2015 12:52:15 -0400 Date: Mon, 21 Sep 2015 18:51:31 +0200 (CEST) From: Thomas Gleixner To: Manoil Claudiu cc: Sudeep Holla , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Rafael J. Wysocki" , "David S. Miller" , Kevin Hao , "netdev@vger.kernel.org" Subject: RE: [PATCH 13/17] net: gianfar: remove misuse of IRQF_NO_SUSPEND flag In-Reply-To: Message-ID: References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-14-git-send-email-sudeep.holla@arm.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Sep 2015, Manoil Claudiu wrote: > >The device is set as wakeup capable using proper wakeup API but the > >driver misuses IRQF_NO_SUSPEND to set the interrupt as wakeup source > >which is incorrect. > > > >This patch removes the use of IRQF_NO_SUSPEND flags replacing it with > >enable_irq_wake instead. > > > > What would be the purpose of IRQF_NO_SUSPEND flag then? The flag is a > friendlier API compared to calling enable_irq_wake(). For older kernels, It's not an API, it's just a bandaid for lazy programmers. > on PPC architectures, the flag did the job. When did this change? Since > when using IRQF_NO_SUSPEND is a "misuse"? It always was. Simply because IRQF_NO_SUSPEND has absolutely nothing to do with wakeup interrupt sources. It's a flag which excludes the interrupt from the suspend mechanism, but it does not flag it a wakeup source. Thanks, tglx