From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757110AbbIUSyB (ORCPT ); Mon, 21 Sep 2015 14:54:01 -0400 Received: from www.linutronix.de ([62.245.132.108]:37776 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756811AbbIUSx7 (ORCPT ); Mon, 21 Sep 2015 14:53:59 -0400 Date: Mon, 21 Sep 2015 20:53:21 +0200 (CEST) From: Thomas Gleixner To: Sudeep Holla cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Linus Walleij , linux-gpio@vger.kernel.org Subject: Re: [PATCH 16/17] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag In-Reply-To: <1442850433-5903-17-git-send-email-sudeep.holla@arm.com> Message-ID: References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-17-git-send-email-sudeep.holla@arm.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Sep 2015, Sudeep Holla wrote: > The IRQF_NO_SUSPEND flag is used to identify the interrupts that should > be left enabled so as to allow them to work as expected during the > suspend-resume cycle, but doesn't guarantee that it will wake the system > from a suspended state, enable_irq_wake is recommended to be used for > the wakeup. > > This patch removes the use of IRQF_NO_SUSPEND flags replacing it with > irq_set_irq_wake instead. > > Cc: Linus Walleij > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Sudeep Holla > --- > drivers/pinctrl/pinctrl-single.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c > index ef04b962c3d5..a5d0f0e52de1 100644 > --- a/drivers/pinctrl/pinctrl-single.c > +++ b/drivers/pinctrl/pinctrl-single.c > @@ -1615,12 +1615,14 @@ static void pcs_irq_unmask(struct irq_data *d) > */ > static int pcs_irq_set_wake(struct irq_data *d, unsigned int state) > { > + struct pcs_soc_data *pcs_soc = irq_data_get_irq_chip_data(d); > + > if (state) > pcs_irq_unmask(d); > else > pcs_irq_mask(d); > > - return 0; > + return irq_set_irq_wake(pcs_soc->irq, state); That's going to create at least a lockdep splat due to nesting irq_desc->lock. Thanks, tglx