From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757591AbbIVKfd (ORCPT ); Tue, 22 Sep 2015 06:35:33 -0400 Received: from www.linutronix.de ([62.245.132.108]:40040 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754111AbbIVKfc (ORCPT ); Tue, 22 Sep 2015 06:35:32 -0400 Date: Tue, 22 Sep 2015 12:34:54 +0200 (CEST) From: Thomas Gleixner To: Oleksij Rempel cc: linux-kernel@vger.kernel.org, marc.zyngier@arm.com, jason@lakedaemon.net, Oleksij Rempel Subject: Re: [PATCH v3 2/2] ARM: irqchip: mxs: add Alphascale ASM9260 support In-Reply-To: <1442836386-4690-3-git-send-email-linux@rempel-privat.de> Message-ID: References: <20150920122843.7cc93682@arm.com> <1442836386-4690-1-git-send-email-linux@rempel-privat.de> <1442836386-4690-3-git-send-email-linux@rempel-privat.de> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Sep 2015, Oleksij Rempel wrote: > static int icoll_irq_domain_map(struct irq_domain *d, unsigned int virq, > irq_hw_number_t hw) > { > - irq_set_chip_and_handler(virq, &mxs_icoll_chip, handle_level_irq); > + struct irq_chip *chip; > + > + if (icoll_priv.type == ICOLL) > + chip = &mxs_icoll_chip; > + else > + chip = &asm9260_icoll_chip; > + > + irq_set_chip_and_handler(virq, chip, handle_level_irq); > set_irq_flags(virq, IRQF_VALID); set_irq_flags() is gone. Please redo against 4.3-rc2 Thanks, tglx