From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934404AbbIVSzI (ORCPT ); Tue, 22 Sep 2015 14:55:08 -0400 Received: from www.linutronix.de ([62.245.132.108]:42571 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759454AbbIVSzE (ORCPT ); Tue, 22 Sep 2015 14:55:04 -0400 Date: Tue, 22 Sep 2015 20:54:19 +0200 (CEST) From: Thomas Gleixner To: Yang Yingliang cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jiang Liu , Marc Zyngier , Mark Rutland , Will Deacon , Russell King - ARM Linux , Hanjun Guo Subject: Re: [RFC PATCH v5 2/4] genirq: add irq_migrate_all_off_this_cpu() for cpu hotplug In-Reply-To: <1442631959-10228-3-git-send-email-yangyingliang@huawei.com> Message-ID: References: <1442631959-10228-1-git-send-email-yangyingliang@huawei.com> <1442631959-10228-3-git-send-email-yangyingliang@huawei.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 19 Sep 2015, Yang Yingliang wrote: > Add irq_migrate_all_off_this_cpu() into kernel/irq/migration.c. This doesn't make any sense at all. You just reuse the existing file to stick your new code into it without reusing a single bit in that file. Aside of that it's unconditionally compiled, which means all existing users of CONFIG_GENERIC_PENDING_IRQ are burdened with pointless code. The right thing to do is: Add that code to a new file: kernel/irq/cpuhotplug.c and make that depend on CONFIG_GENERIC_IRQ_MIGRATION. Thanks, tglx