From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934581AbbIVUDs (ORCPT ); Tue, 22 Sep 2015 16:03:48 -0400 Received: from www.linutronix.de ([62.245.132.108]:42915 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933208AbbIVUDr (ORCPT ); Tue, 22 Sep 2015 16:03:47 -0400 Date: Tue, 22 Sep 2015 22:03:08 +0200 (CEST) From: Thomas Gleixner To: Dave Hansen cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 10/26] x86, pkeys: notify userspace about protection key faults In-Reply-To: <20150916174906.51062FBC@viggo.jf.intel.com> Message-ID: References: <20150916174903.E112E464@viggo.jf.intel.com> <20150916174906.51062FBC@viggo.jf.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Sep 2015, Dave Hansen wrote: > > +static inline u16 vma_pkey(struct vm_area_struct *vma) > +{ > + u16 pkey = 0; > +#ifdef CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS > + unsigned long f = vma->vm_flags; > + pkey |= (!!(f & VM_HIGH_ARCH_0)) << 0; > + pkey |= (!!(f & VM_HIGH_ARCH_1)) << 1; > + pkey |= (!!(f & VM_HIGH_ARCH_2)) << 2; > + pkey |= (!!(f & VM_HIGH_ARCH_3)) << 3; Eew. What's wrong with: pkey = (vma->vm_flags & VM_PKEY_MASK) >> VM_PKEY_SHIFT; ??? > +static u16 fetch_pkey(unsigned long address, struct task_struct *tsk) So here we get a u16 and assign it to si_pkey > + if (boot_cpu_has(X86_FEATURE_OSPKE) && si_code == SEGV_PKUERR) > + info.si_pkey = fetch_pkey(address, tsk); which is int. > + int _pkey; /* FIXME: protection key value?? Inconsistent at least. Thanks, tglx