From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934585AbbIVUFq (ORCPT ); Tue, 22 Sep 2015 16:05:46 -0400 Received: from www.linutronix.de ([62.245.132.108]:42926 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933524AbbIVUFp (ORCPT ); Tue, 22 Sep 2015 16:05:45 -0400 Date: Tue, 22 Sep 2015 22:05:06 +0200 (CEST) From: Thomas Gleixner To: Dave Hansen cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 11/26] x86, pkeys: add functions for set/fetch PKRU In-Reply-To: <20150916174906.4F375766@viggo.jf.intel.com> Message-ID: References: <20150916174903.E112E464@viggo.jf.intel.com> <20150916174906.4F375766@viggo.jf.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Sep 2015, Dave Hansen wrote: > > This adds the raw instructions to access PKRU as well as some > accessor functions that correctly handle when the CPU does > not support the instruction. We don't use them here, but > we will use read_pkru() in the next patch. > > I do not see an immediate use for write_pkru(). But, we put it > here for partity with its twin. So that read_pkru() doesn't feel so lonely? I can't follow that logic. Thanks, tglx