From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755288AbbI0Krb (ORCPT <rfc822;w@1wt.eu>);
	Sun, 27 Sep 2015 06:47:31 -0400
Received: from www.linutronix.de ([62.245.132.108]:56800 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755105AbbI0Kra (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 27 Sep 2015 06:47:30 -0400
Date: Sun, 27 Sep 2015 12:46:28 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Andy Lutomirski <luto@amacapital.net>
cc: James Forcier <csssuf@csssuf.net>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>, Jan Beulich <JBeulich@suse.com>,
        X86 ML <x86@kernel.org>,
        "Juergen Gross <jgross@suse.com, Toshi Kani" <toshi.kani@hp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Luis R. Rodriguez" <mcgrof@suse.com>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86/mm: Export cpu_tlbstate as non-GPL symbol
In-Reply-To: <CALCETrVJbkAZr+TzmHnubnf+kGV=+Z5fezZTswNMZzHs_yf+Gg@mail.gmail.com>
Message-ID: <alpine.DEB.2.11.1509271244140.4500@nanos>
References: <1442947897-14487-1-git-send-email-csssuf@csssuf.net> <CALCETrXSyNX-jO4i_Guu_TT-86JoN0RuVGjbVTQcrCMDwuz-5g@mail.gmail.com> <alpine.DEB.2.11.1509222056210.5606@nanos> <CALCETrVJbkAZr+TzmHnubnf+kGV=+Z5fezZTswNMZzHs_yf+Gg@mail.gmail.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 24 Sep 2015, Andy Lutomirski wrote:
> On Sep 22, 2015 11:58 AM, "Thomas Gleixner" <tglx@linutronix.de> wrote:
> >
> > On Tue, 22 Sep 2015, Andy Lutomirski wrote:
> > > On Tue, Sep 22, 2015 at 11:51 AM, James Forcier <csssuf@csssuf.net> wrote:
> > > > Exporting cpu_tlbstate as a GPL symbol was introduced in 1e02ce4c; however, this
> > > > breaks non-GPL modules which need to link against it, particularly the AMD
> > > > Catalyst drivers.
> > >
> > > What is AMD Catalyst doing with cpu_tlbstate?
> >
> > Fiddling with it behind the kernels back. Out of tree graphic drivers
> > always have their special needs. Just lookup the discussions about
> > unexporting init_mm ....
> 
> Look for kcl_mem_pat_setup here:
> 
> https://github.com/kolasa/fglrx-13.152/blob/master/firegl_public.c

I stopped looking at this line:

MODULE_LICENSE("GPL\0Proprietary. (C) 2002 - ATI Technologies, Starnberg, GERMANY");
 
Thanks,

	tglx